Skip to content

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Oct 6, 2025

User description

💥 What does this PR do?

🔄 Types of changes

  • Build/Test

PR Type

Tests


Description

  • Fix Windows path handling in Selenium Manager tests

  • Split Linux test into separate x86_64 and arm64 cases

  • Workaround for Bazel issues on Windows


Diagram Walkthrough

flowchart LR
  A["Windows Path Issues"] --> B["Fix Path Separators"]
  C["Linux Test Issues"] --> D["Split Architecture Tests"]
  B --> G["Tests Pass on Windows"]
  D --> G
Loading

File Walkthrough

Relevant files
Tests
selenium_manager_tests.py
Fix Windows paths and split Linux tests                                   

py/test/selenium/webdriver/common/selenium_manager_tests.py

  • Fix Windows path separators using raw strings and platform detection
  • Split Linux test into separate x86_64 and arm64 test functions
  • Mock platform.machine() for consistent test behavior
  • Update assertion messages to use dynamic path variables

@selenium-ci selenium-ci added C-py Python Bindings B-build Includes scripting, bazel and CI integrations labels Oct 6, 2025
@cgoldberg cgoldberg merged commit 3f9c5cb into SeleniumHQ:trunk Oct 7, 2025
18 checks passed
@cgoldberg cgoldberg deleted the py-fix-selenium-manager-tests-windows branch October 7, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-build Includes scripting, bazel and CI integrations C-py Python Bindings Review effort 2/5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants